Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: Include Index in listTags response #803

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

jelly
Copy link
Contributor

@jelly jelly commented Oct 5, 2021

A search without the listTags option normally returns the Index, but as
searchRepositoryTags builds the SearchResult struct the Index was not
included.

Signed-off-by: Jelle van der Waa jvanderwaa@redhat.com

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In order to pass CI, please run go fmt on the changed file.

@jelly
Copy link
Contributor Author

jelly commented Oct 5, 2021

LGTM

In order to pass CI, please run go fmt on the changed file.

Sorry, will do.

What do you think of making the Index output consistent when listing tags of registry.fedoraproject.org as this change will make it inconsistent?

@vrothberg
Copy link
Member

What do you think of making the Index output consistent when listing tags of registry.fedoraproject.org as this change will make it inconsistent?

The output of podman doesn't change with this PR (I tested locally), so I think we're good.

A search without the listTags option normally returns the Index, but as
searchRepositoryTags builds the SearchResult struct the Index was not
included.

Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Oct 7, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jelly, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 7, 2021
@rhatdan rhatdan merged commit eaf9dd6 into containers:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants